Skip to content

Consolidate checkpoint contract with checkpoint component#867

Closed
Miiira wants to merge 1 commit intometa-pytorch:mainfrom
Miiira:export-D40734262
Closed

Consolidate checkpoint contract with checkpoint component#867
Miiira wants to merge 1 commit intometa-pytorch:mainfrom
Miiira:export-D40734262

Conversation

@Miiira
Copy link
Contributor

@Miiira Miiira commented Oct 30, 2022

Summary: load_state_dict should be used with None datapipe input to avoid confusion: datapipe inside state dict will be the ground truth in reading

Reviewed By: xunnanxu

Differential Revision: D40734262

Summary: `load_state_dict` should be used with `None` datapipe input to avoid confusion: datapipe inside state dict will be the ground truth in reading

Reviewed By: xunnanxu

Differential Revision: D40734262

fbshipit-source-id: fce01106dbf379bae3f97c34e33aa64788c5591a
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Oct 30, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40734262

facebook-github-bot pushed a commit that referenced this pull request Nov 1, 2022
Summary:
Per title. This is a forward fix of #867

Pull Request resolved: #870

Reviewed By: NivekT

Differential Revision: D40896052

Pulled By: ejguan

fbshipit-source-id: c970402a7ba99e44bf15980029bbe89b33a99c24
@ejguan ejguan added the topic: improvements topic category label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: improvements topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants