Open
Conversation
Contributor
|
Could you explain the details? Also, which CMake version did you target (cpuinfo currently targets CMake 2.8, but we can update it to 3.5. Going above 3.5, however, would be hard as some cpuinfo users target 3.5) |
Author
|
Definitely not above 3.5. I think 3.0. |
eb570f1 to
e574dc1
Compare
e574dc1 to
868bd11
Compare
Author
|
Just a note: If you set the Travis CI to use the version of CMake you desire, then you never need to worry about compatibility -- it would fail to compile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install config for cpuinfo so that it can found with find_package(cpuinfo) and used with target_link_libraries(... cpuinfo::cpuinfo)