Add darwin_x86_64 CPU handling#139
Merged
Maratyszcza merged 1 commit intopytorch:mainfrom Jul 14, 2023
keith:ks/add-darwin_x86_64-cpu-handling
Merged
Add darwin_x86_64 CPU handling#139Maratyszcza merged 1 commit intopytorch:mainfrom keith:ks/add-darwin_x86_64-cpu-handling
Maratyszcza merged 1 commit intopytorch:mainfrom
keith:ks/add-darwin_x86_64-cpu-handling
Conversation
Currently bazel supports `darwin` and `darwin_x86_64` as meaning the same thing. The fully qualified version is normally used if you're cross compiling from M1 machines to intel machines. I'm also hoping to remove the unqualified version to reduce confusion. This change makes cpuinfo compatible with both for now.
Maratyszcza
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently bazel supports
darwinanddarwin_x86_64as meaning the same thing. The fully qualified version is normally used if you're cross compiling from M1 machines to intel machines. I'm also hoping to remove the unqualified version to reduce confusion. This change makes cpuinfo compatible with both for now.