This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Add magma build for CUDA 11#461
Merged
seemethere merged 2 commits intopytorch:masterfrom Aug 3, 2020
zasdfgbnm:cuda11-magma
Merged
Add magma build for CUDA 11#461seemethere merged 2 commits intopytorch:masterfrom zasdfgbnm:cuda11-magma
seemethere merged 2 commits intopytorch:masterfrom
zasdfgbnm:cuda11-magma
Conversation
malfet
reviewed
Jun 18, 2020
magma/magma-cuda110/cmakelists.patch
Outdated
|
|
||
| + if ( ${GPU_TARGET} MATCHES "All") | ||
| + set( MIN_ARCH 370) | ||
| + SET( NV_SM -gencode arch=compute_37,code=sm_37 -gencode arch=compute_50,code=sm_50 -gencode arch=compute_60,code=sm_60 -gencode arch=compute_70,code=sm_70 ) |
Contributor
There was a problem hiding this comment.
Hmm, don't you want to add compute_80 here?
Contributor
Author
There was a problem hiding this comment.
Good catch! I remembered I added it here but looks like I was wrong. Fixed now.
malfet
reviewed
Jun 18, 2020
Comment on lines
+7
to
+8
| -option( USE_FORTRAN "Fortran is required for some tester checks, but can be disabled with reduced functionality" ON ) | ||
| +option( USE_FORTRAN "Fortran is required for some tester checks, but can be disabled with reduced functionality" OFF ) |
Contributor
There was a problem hiding this comment.
Why this change is needed, if cmake is called with -DUSE_FORTRAN=OFF?
Contributor
Author
There was a problem hiding this comment.
I don't know, this part is copied from CUDA 10.2 patch.
malfet
approved these changes
Jun 18, 2020
|
Any guess when this might be merged? |
Contributor
Author
|
@dawonn-haval I believe it will be merged soon after 1.6 release of pytorch |
seemethere
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from 10.2 with additional changes.