Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

[aarch64] cherry-pick Xbyak crash fix and linter error fixes from main#1649

Merged
malfet merged 4 commits intopytorch:release/2.2from
snadampal:xbyak_fix_rel2.2
Jan 3, 2024
Merged

[aarch64] cherry-pick Xbyak crash fix and linter error fixes from main#1649
malfet merged 4 commits intopytorch:release/2.2from
snadampal:xbyak_fix_rel2.2

Conversation

@snadampal
Copy link
Copy Markdown
Contributor

@snadampal snadampal commented Dec 21, 2023

cc: @atalman

snadampal and others added 4 commits December 21, 2023 13:26
pytorch is moved to oneDNN v3.3.2 and some of the
 old patches are not applicable any more.
There are platforms with /sys not mounted. skip handling HW caps
for such platforms.

cherry-pick of: uxlfoundation/oneDNN#1773
This fixes the issue# pytorch/pytorch#115482
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a cherry-pick of above-mentioned commit, is it?

@snadampal
Copy link
Copy Markdown
Contributor Author

hi @malfet this is a cherrypick of 4 commits from main. I picked all 4 so that they apply cleanly.
do you mean (1) let's pick only the last one and rework it to apply on 2.2 branch? or
(2) pick only the subset of changes went into xbyak repo? fujitsu/xbyak_aarch64#96

@atalman
Copy link
Copy Markdown
Contributor

atalman commented Dec 28, 2023

@snadampal Could you please mention all 4 cherry-picks in the issue tracker here: pytorch/pytorch#115300 (comment) this way we are sure which commits are getting cherry-picked

@snadampal
Copy link
Copy Markdown
Contributor Author

Hi @malfet , @atalman , updated the tracker with all the 4 commits.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants