Add XLA support to moco benchmark.#2292
Closed
ysiraichi wants to merge 2 commits intopytorch:mainfrom
Closed
Conversation
Contributor
Author
|
The CI failures don't seem related to this PR. |
This was referenced Jun 12, 2024
albanD
approved these changes
Jun 19, 2024
Contributor
albanD
left a comment
There was a problem hiding this comment.
Sounds good to me.
FYI @aaronenyeshi and @JackCaoG
| ) | ||
| except RuntimeError: | ||
| pass # already initialized? | ||
| elif device.startswith("xla"): |
Contributor
There was a problem hiding this comment.
nit for consistency device == "xla" ?
4c46871 to
eb46de2
Compare
xuzhao9
approved these changes
Jun 19, 2024
Contributor
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
aaronenyeshi
approved these changes
Jun 19, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tweaks
mocobenchmark, so that it will also run on XLA devices. Previously,mocohardcoded the CUDA device in two ways:ProcessGroupwithncclbackend, onlycuda, explicitlyIn order to add XLA support, this PR:
xla*devices and, if detected, initializes theProcessGroupwithxlabackendcc @lezcano