Replace direct calls to setup.py with pip equivalents#4009
Merged
NicolasHug merged 1 commit intopytorch:mainfrom Aug 4, 2025
Merged
Replace direct calls to setup.py with pip equivalents#4009NicolasHug merged 1 commit intopytorch:mainfrom
NicolasHug merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4009
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 63f5a16 with merge base b757cc6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
approved these changes
Aug 4, 2025
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks for the PR @zklaus
I think we have deactivated most of those in the CI at the moment, but the linux CPU tests are happy, so that's what matters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct invocation of
setup.pyis deprecated and in particular the callspython setup.py installandpython setup.py developwill go away as soon as October. To keep up with the ecosystem and Pytorch itself, this replaces all such calls with their modern equivalents.For more details, also see the Pytorch issue pytorch/pytorch#152276.
For a similar PR in torchvision, see pytorch/vision#9161.