[xpu][test] Skip WIP config for Intel GPU in test_safetensors_support.py and test_x86inductor_fusion.py#4049
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4049
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit fd653f3 with merge base fe98658 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
@liangan1 Please help to review this pr. It block xpu-ci. |
|
@Stonepia Please help to review. |
| @@ -63,7 +63,7 @@ | |||
| ] | |||
|
|
|||
There was a problem hiding this comment.
XPU uses a different path for INT4 woq in the line 60., so we add skip here.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes. you are right. We need to test XPU on https://github.com/zxd1997066/ao/blob/3fde9ea2707775d23b773a5bb4e8afeaffc00aa6/test/prototype/safetensors/test_safetensors_support.py#L60 and skip line 52 which is only for CUDA.
|
|
||
| # MX and NVFP4 configs require torch >= 2.11 | ||
| if torch_version_at_least("2.11.0.dev"): | ||
| if not torch.xpu.is_available() and torch_version_at_least("2.11.0.dev"): |
There was a problem hiding this comment.
MX format is not enable yet on Intel XPU.
3fde9ea to
bc7893b
Compare
bc7893b to
01d473c
Compare
| # Int4WeightOnlyConfig with tinygemm uses sm90a CUTLASS kernels which are not | ||
| # forward-compatible with sm100+ | ||
| if not is_sm_at_least_100(): | ||
| if not torch.xpu.is_available() and not is_sm_at_least_100(): |
There was a problem hiding this comment.
these xpu conditions are spread across the code base and makes it confusing on what is and is not supported on cuda and xpu, can you just have 1 branch for xpu and one branch for not xpu to make things clearer
There was a problem hiding this comment.
Thanks, refined the code.
01d473c to
dbf1641
Compare
There was a problem hiding this comment.
also this is pretty weird, why do we get the last device in _DEVICES?
There was a problem hiding this comment.
removed this line.
There was a problem hiding this comment.
I think you'll want to refactor this to use get_available_devices as well, like other files
| ] | ||
|
|
||
| # plain_int32 only supports XPU | ||
| if _DEVICE in ("xpu"): |
There was a problem hiding this comment.
probably should be if torch.xpu.is_available() to be consistent with other conditions
| @unittest.skipIf( | ||
| torch_version_at_least("2.11.0.dev"), "Doesn't work with torch 2.11.0.dev+" | ||
| ) | ||
| @unittest.skipIf(torch.xpu.is_available(), "Doesn't support for XPU") |
There was a problem hiding this comment.
nit: Doesn't work with XPU
For #2917, This PR is targeted to skip WIP config for Intel GPU in test/prototype/safetensors/test_safetensors_support.py and test/quantization/pt2e/test_x86inductor_fusion.py