Revert "[rocm] scaled_grouped_mm support gfx942 fp8 data type"#3713
Merged
Conversation
This reverts commit 2540ac4.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3713
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d7f0b50 with merge base 81d7755 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
vkuzo
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3540
Unfortunately we need to revert this as it seems to have broken MoE training as some callsites haven't been properly updated to correctly handle the new param. Starting next week we'll support emulated mode to run these tests in CI, but in the meantime, we need to fix and run the tests locally before relanding @xiaobochen-amd
the tests are in this dir: https://github.com/pytorch/ao/tree/main/test/prototype/moe_training
the TP tests aren't expected to pass yet, but everything else should.