Unskip test_qat_8da4w_prepare_vs_convert#2131
Closed
andrewor14 wants to merge 1 commit into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2131
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d807ed4 with merge base cdced21 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
46dd57e to
7d76707
Compare
7d76707 to
138aeca
Compare
Merged
Collaborator
|
thanks @andrewor14 let me test in on rocm as well. |
Contributor
Author
|
Seems like it's still failing, need to investigate further |
138aeca to
016625c
Compare
Contributor
Author
|
Ok I think I fixed it for fp16 as well. @petrex try again? |
Following @metascroy's investigation in #2085, we can unskip this test, which was caused by activation scales having different precisions between prepare and convert. **Test Plan:** python test/quantization/test_qat.py -k test_qat_8da4w_prepare_vs_convert
016625c to
d807ed4
Compare
Contributor
Author
|
Unskipped as part of #2085 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following @metascroy's investigation in #2085, we can unskip this test, which was caused by activation scales having different precisions between prepare and convert.
Test Plan:
python test/quantization/test_qat.py -k test_qat_8da4w_prepare_vs_convert