Merged
Conversation
fa53986 to
6ea89ae
Compare
peri044
reviewed
Sep 24, 2025
Collaborator
There was a problem hiding this comment.
Could you add detailed comments demonstrating what it does now that you've gone through the entire converter ? that would be helpful
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
narendasan
reviewed
Sep 24, 2025
9e7ca5d to
c286767
Compare
narendasan
reviewed
Oct 7, 2025
| gm.graph.erase_node(node) | ||
| gm = clean_up_graph_after_modifications(gm) | ||
|
|
||
| gm = clean_up_graph_after_modifications(gm) |
Collaborator
There was a problem hiding this comment.
Is this just because we only need one cleanup?
Collaborator
Author
There was a problem hiding this comment.
Yeah or otherwise it could take forever
peri044
reviewed
Oct 7, 2025
narendasan
approved these changes
Oct 8, 2025
Collaborator
narendasan
left a comment
There was a problem hiding this comment.
LGTM but please also get @peri044's stamp
peri044
approved these changes
Oct 8, 2025
Collaborator
|
@cehongwang the linux tests are failing. Do you know the rootcause ? |
92f62f8 to
049b810
Compare
Collaborator
Author
fixed |
015bf19 to
6cf31cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: