Merged
Conversation
peri044
reviewed
Aug 30, 2025
Collaborator
peri044
left a comment
There was a problem hiding this comment.
Minor comments. Please update the supported models section in README.md and docs/user_guide.
peri044
reviewed
Sep 2, 2025
Collaborator
peri044
left a comment
There was a problem hiding this comment.
- Could you quickly try running these variants as well ?
a) google/gemma-3-4b-it
b) google/gemma-3-270m-it - Please update the supported model list here as well: https://github.com/pytorch/TensorRT/blob/main/docsrc/tutorials/compile_hf_models.rst
- Could you add a testcase for 1 Gemma-3 decoder layer with sliding window attention ? The test case could be located at https://github.com/pytorch/TensorRT/tree/main/tests/py/dynamo/models as test_llm_models.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: