fix: atan2 strong type support & bug fix for integer dynamic shape#3751
fix: atan2 strong type support & bug fix for integer dynamic shape#3751
Conversation
lanluo-nvidia
left a comment
There was a problem hiding this comment.
LGTM
(I have verified this fix is working when use_explicit_typing is true)
|
From the CI logs, it seems the issue might be caused by the change I made to generate integer random inputs for dynamic shapes. Previously, the inputs were all zeros, so the problem didn’t surface. I’ll look into fixing this part. If strong type support for atan2 is urgent, I can remove the dynamic shape input change from this PR and submit it separately. Let me know what you think.
|
|
I will create a separate issue for |
Description
atan2converter.atan2: previously usedπ/2 * inputinstead of creating a constant tensor filled withπ/2. This only passed tests because the input was zero.torch.rand()withtorch.randint()for integer inputs in dynamic shape tests — this change may affect other converters using integer dynamic inputs.Type of change
Please delete options that are not relevant and/or add your own.
Checklist: