Skip to content

fix: torch 2.7 bump bug on the main branch#3353

Merged
zewenli98 merged 7 commits intomainfrom
fix_torch2.7_bump_bug
Jan 17, 2025
Merged

fix: torch 2.7 bump bug on the main branch#3353
zewenli98 merged 7 commits intomainfrom
fix_torch2.7_bump_bug

Conversation

@zewenli98
Copy link
Copy Markdown
Collaborator

@zewenli98 zewenli98 commented Jan 11, 2025

Description

fix torch 2.7 bump bug on the main branch

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Jan 11, 2025
@github-actions github-actions bot added the component: build system Issues re: Build system label Jan 11, 2025
@github-actions github-actions bot requested a review from narendasan January 11, 2025 06:24
@HolyWu
Copy link
Copy Markdown
Contributor

HolyWu commented Jan 11, 2025

You have to also bump both torch and torchvision at

TensorRT/py/requirements.txt

Lines 5 to 6 in 543bc9b

torch>=2.6.0.dev,<2.7.0
torchvision>=0.20.0.dev,<0.21.0
, otherwise CI couldn't find the correct version to install. For torch>=2.7.0.dev you'll need torchvision>=0.22.0.dev.

@github-actions github-actions bot added the component: api [Python] Issues re: Python API label Jan 14, 2025
@zewenli98 zewenli98 force-pushed the fix_torch2.7_bump_bug branch from d975cab to 2c2a4f6 Compare January 14, 2025 18:38
@narendasan
Copy link
Copy Markdown
Collaborator

narendasan commented Jan 14, 2025

You have to also bump both torch and torchvision at

TensorRT/py/requirements.txt

Lines 5 to 6 in 543bc9b

torch>=2.6.0.dev,<2.7.0
torchvision>=0.20.0.dev,<0.21.0

, otherwise CI couldn't find the correct version to install. For torch>=2.7.0.dev you'll need torchvision>=0.22.0.dev.

@zewenli98 something for post 2.6 release, we should move CI to pip wheel and just use pyproject.toml from now on.

@zewenli98 zewenli98 force-pushed the fix_torch2.7_bump_bug branch from 74faecd to 9f3a7eb Compare January 15, 2025 21:24
@zewenli98 zewenli98 merged commit d6be4ba into main Jan 17, 2025
@zewenli98 zewenli98 deleted the fix_torch2.7_bump_bug branch January 12, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@zewenli98 zewenli98

Labels

cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zewenli98 @HolyWu @narendasan @facebook-github-bot