Skip to content

Bump TRT version to 10.7#3313

Merged
zewenli98 merged 4 commits intomainfrom
bump_to_trt10.7
Jan 2, 2025
Merged

Bump TRT version to 10.7#3313
zewenli98 merged 4 commits intomainfrom
bump_to_trt10.7

Conversation

@zewenli98
Copy link
Copy Markdown
Collaborator

Description

Bump TRT version to 10.7

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Dec 6, 2024
@zewenli98 zewenli98 marked this pull request as draft December 6, 2024 00:23
@github-actions github-actions bot added component: build system Issues re: Build system component: api [Python] Issues re: Python API labels Dec 11, 2024
@zewenli98 zewenli98 marked this pull request as ready for review December 12, 2024 19:35
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

pyproject.toml Outdated
"typing-extensions>=4.7.0",
"future>=0.18.3",
"tensorrt-cu12>=10.6.0,<10.8.0",
"tensorrt-cu12==10.7.0",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do multiple TRT versions get tested now in CI with this change ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should right? Also 10.6 should be supported but we need at least 10.6 because of the QDP feature

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean we need to keep tensorrt-cu12>=10.6.0,<10.8.0?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@github-actions github-actions bot removed the component: build system Issues re: Build system label Dec 31, 2024
Copy link
Copy Markdown
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zewenli98 zewenli98 merged commit 50f29cb into main Jan 2, 2025
@zewenli98 zewenli98 deleted the bump_to_trt10.7 branch January 12, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants