Skip to content

extend the timeout-minutes in build/test from 60 min to 120 min#3203

Merged
lanluo-nvidia merged 1 commit intomainfrom
lluo/fix_timeout
Oct 3, 2024
Merged

extend the timeout-minutes in build/test from 60 min to 120 min#3203
lanluo-nvidia merged 1 commit intomainfrom
lluo/fix_timeout

Conversation

@lanluo-nvidia
Copy link
Copy Markdown
Collaborator

@lanluo-nvidia lanluo-nvidia commented Oct 2, 2024

Description

extend the timeout-minutes in build/test from 60 min to 120 min

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia self-assigned this Oct 2, 2024
narendasan
narendasan approved these changes Oct 2, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any idea why builds are slowing down

@lanluo-nvidia lanluo-nvidia merged commit cc0cd07 into main Oct 3, 2024
@lanluo-nvidia
Copy link
Copy Markdown
Collaborator Author

lanluo-nvidia commented Oct 3, 2024 •
edited
Loading

LGTM, any idea why builds are slowing down

I have manually checked the timed-out windows build and non-timed-out windows build, our torchtrt build is around 30 min.
The difference is the previous steps sometimes are running over 30 min(which is not in our control)

Also I have checked some successful ones recently and even earlier 2.4 release are around 50-55 min, so it is already very close to 60 min.

@HolyWu
Copy link
Copy Markdown
Contributor

HolyWu commented Oct 6, 2024

@narendasan @lanluo-nvidia The recent slowing down or timed out builds on Windows was caused by pytorch/test-infra#5722. As a result the substitute-runner job I inserted couldn't find the string to replace. Simply changing windows.8xlarge.nvidia.gpu to windows.g4dn.xlarge should make it work again.

@lanluo-nvidia lanluo-nvidia deleted the lluo/fix_timeout branch January 9, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@lanluo-nvidia lanluo-nvidia

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lanluo-nvidia @HolyWu @narendasan @facebook-github-bot