Skip to content

upgrade modelopt#3160

Merged
lanluo-nvidia merged 5 commits intomainfrom
lluo/modelopt_upgrade
Sep 16, 2024
Merged

upgrade modelopt#3160
lanluo-nvidia merged 5 commits intomainfrom
lluo/modelopt_upgrade

Conversation

@lanluo-nvidia
Copy link
Copy Markdown
Collaborator

@lanluo-nvidia lanluo-nvidia commented Sep 13, 2024

Description

upgrade modelopt

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia self-assigned this Sep 13, 2024
@lanluo-nvidia lanluo-nvidia added WIP Work is in progress, pull request should not be merged yet and removed cla signed labels Sep 13, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: build system Issues re: Build system labels Sep 13, 2024
@github-actions github-actions bot requested a review from narendasan September 13, 2024 17:30
@HolyWu
Copy link
Copy Markdown
Contributor

HolyWu commented Sep 14, 2024

Besides CI failure, I think torchtrt won't need the onnx submodule of modelopt. So instead of nvidia-modelopt[all] you can use nvidia-modelopt[deploy,hf,torch] to save some installation space and time. Also don't forget

TensorRT/tests/py/dynamo/models/test_models_export.py

Lines 254 to 255 in 5719928

or Version(metadata.version("nvidia-modelopt")) < Version("0.16.1"),
"modelopt 0.16.1 or later is required Int8 quantization is supported in modelopt since 0.16.1 or later",

@lanluo-nvidia lanluo-nvidia removed the WIP Work is in progress, pull request should not be merged yet label Sep 14, 2024
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review September 15, 2024 17:21
narendasan
narendasan reviewed Sep 16, 2024
View reviewed changes
@lanluo-nvidia lanluo-nvidia merged commit dbc41ce into main Sep 16, 2024
@lanluo-nvidia lanluo-nvidia deleted the lluo/modelopt_upgrade branch January 9, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan left review comments

Assignees

@lanluo-nvidia lanluo-nvidia

Labels

cla signed component: build system Issues re: Build system component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lanluo-nvidia @HolyWu @narendasan @facebook-github-bot