Skip to content

fix: Segfault fix for Benchmarks#2432

Merged
narendasan merged 2 commits intopytorch:mainfrom
gs-olive:segfault_fix
Nov 3, 2023
Merged

fix: Segfault fix for Benchmarks#2432
narendasan merged 2 commits intopytorch:mainfrom
gs-olive:segfault_fix

Conversation

@gs-olive
Copy link
Copy Markdown
Contributor

@gs-olive gs-olive commented Nov 2, 2023

Description

  • Segfault fix for benchmarking on Docker container with CUDNN 8.8
  • Likely due to Torch 2.1.0 based on CUDNN 8.9

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
    • Tested manually in Docker
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Segfault fix for Benchmarks
fe8b97b 
- Segfault fix for benchmarking on Docker container with CUDNN 8.8
- Likely due to Torch 2.1.0 based on CUDNN 8.9
gs-olive
gs-olive commented Nov 2, 2023
View reviewed changes
tools/perf/perf_run.py
)
args = arg_parser.parse_args()

cudnn.benchmark = True
Copy link
Copy Markdown
Contributor Author

@gs-olive gs-olive Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narendasan - this line causes a segfault at inference time, when we compile the Docker container with CUDNN 8.8, and Torch 2.1.0 uses the CUDNN 8.9 Python distributions. When removed, inference works as expected.

Do you think it would be necessary/important to upgrade the build stack to CUDNN 8.9 for the upcoming release?

@github-actions github-actions bot added the component: build system Issues re: Build system label Nov 2, 2023
narendasan
narendasan approved these changes Nov 2, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 19a11c2 into pytorch:main Nov 3, 2023
@gs-olive gs-olive mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

No one assigned

Labels

cla signed component: build system Issues re: Build system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gs-olive @narendasan @facebook-github-bot