Skip to content

fix: Upgrade perf benchmark system#2428

Merged
peri044 merged 1 commit intopytorch:perf_refactorfrom
gs-olive:upgrade_perf_benchmark_system
Nov 1, 2023
Merged

fix: Upgrade perf benchmark system#2428
peri044 merged 1 commit intopytorch:perf_refactorfrom
gs-olive:upgrade_perf_benchmark_system

Conversation

@gs-olive
Copy link
Copy Markdown
Contributor

@gs-olive gs-olive commented Nov 1, 2023

Description

  • Switch model dictionary to lazy-loading scheme
  • Change model references to name-based instead of file-based

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

- Switch model dictionary to lazy-loading scheme
- Change model references to name-based instead of file-based
Copy link
Copy Markdown
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comment for future


scripted_filename = "models/" + n + "_scripted.jit.pt"
traced_filename = "models/" + n + "_traced.jit.pt"
pytorch_filename = "models/" + n + "_pytorch.pt"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove saving pytorch models now ?

@peri044 peri044 merged commit 5763274 into pytorch:perf_refactor Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants