Skip to content

feat: support tile dynamo converter#2402

Merged
apbose merged 2 commits intopytorch:mainfrom
zewenli98:tile_dynamo_converter
Nov 1, 2023
Merged

feat: support tile dynamo converter#2402
apbose merged 2 commits intopytorch:mainfrom
zewenli98:tile_dynamo_converter

Conversation

@zewenli98
Copy link
Copy Markdown
Collaborator

@zewenli98 zewenli98 commented Oct 17, 2023 •
edited
Loading

Description

Support tile dynamo converter. This is a part of slice converter.

Fixes part of #2215

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Oct 17, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Oct 17, 2023
@github-actions github-actions bot requested a review from peri044 October 17, 2023 21:47
@gs-olive gs-olive requested a review from apbose October 20, 2023 18:39
@zewenli98 zewenli98 force-pushed the tile_dynamo_converter branch from 557cb25 to 58c8f2f Compare October 26, 2023 00:43
apbose
apbose reviewed Oct 26, 2023
View reviewed changes
py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py Outdated
shapes = []
for i, (s, d) in enumerate(zip(input.shape, dims)):
shapes.append(
impl.elementwise.mul(ctx, target, source_ir, f"{name}_mul_{i}", s, d)
Copy link
Copy Markdown
Collaborator

@apbose apbose Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this part, if in the function definition the dims is Sequence[int]?
I am assuming it is for the case where the dims is a sequence of ITensors? Then accordingly maybe the function definition needs to be changed?

Copy link
Copy Markdown
Collaborator Author

@zewenli98 zewenli98 Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the else part is not needed. Thanks for comments!

@zewenli98 zewenli98 requested a review from apbose October 26, 2023 22:50
apbose
apbose reviewed Oct 27, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@apbose apbose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a minor clarification I wanted, in this I see that dims are SymInt[] so that should be fine for int based arithmetic operations right?

@zewenli98
Copy link
Copy Markdown
Collaborator Author

zewenli98 commented Oct 27, 2023

Yes, I think symInt is kind of like int per the doc. @gs-olive Could you help us confirm we can use int when seeing symInt in the schema?

@zewenli98 zewenli98 requested a review from apbose October 27, 2023 20:48
@gs-olive
Copy link
Copy Markdown
Contributor

gs-olive commented Oct 30, 2023

Hi - generally SymInt and int are not interchangeable, since int is a concrete value whereas SymInt does not generally have a fixed or concrete value. In the test cases, are the values you encounter in args[1] ints or SymInts when calling this function?

@zewenli98
Copy link
Copy Markdown
Collaborator Author

zewenli98 commented Oct 30, 2023

Hi, in the tests we pass in int[] and also get int[] for args[1]

@gs-olive
Copy link
Copy Markdown
Contributor

gs-olive commented Oct 30, 2023

In that case, we should be typing everything with int and not SymInt, since we are not able to support Dynamic shape through SymInt now anyway.

@zewenli98 zewenli98 force-pushed the tile_dynamo_converter branch from d4a83ac to 222902d Compare October 31, 2023 21:10
@zewenli98 zewenli98 force-pushed the tile_dynamo_converter branch from 222902d to 4d71e91 Compare October 31, 2023 23:32
@apbose apbose merged commit 5578763 into pytorch:main Nov 1, 2023
@zewenli98 zewenli98 deleted the tile_dynamo_converter branch January 12, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apbose apbose apbose approved these changes

@peri044 peri044 Awaiting requested review from peri044

Assignees

@zewenli98 zewenli98

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zewenli98 @gs-olive @apbose @facebook-github-bot