Skip to content

Upstream 3 features for torch-trt: ms, VC, and optimisation level#1926

Closed
wu6u3tw wants to merge 11 commits intopytorch:mainfrom
wu6u3tw:dev-tinyinl-upstream-patch
Closed

Upstream 3 features for torch-trt: ms, VC, and optimisation level#1926
wu6u3tw wants to merge 11 commits intopytorch:mainfrom
wu6u3tw:dev-tinyinl-upstream-patch

Conversation

@wu6u3tw
Copy link
Copy Markdown
Contributor

@wu6u3tw wu6u3tw commented May 17, 2023 •
edited
Loading

Description

Upstream options:

  • max_aux_streams
  • version_compatible
  • optimization_level

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot requested review from frank-wei May 17, 2023 00:31
@wu6u3tw wu6u3tw changed the title Upstream Upstream 3 features for torch-trt: ms, VC, and optimisation level May 17, 2023
@wu6u3tw
Copy link
Copy Markdown
Contributor Author

wu6u3tw commented May 17, 2023

@nvpohanh for viz.

nvpohanh
nvpohanh reviewed May 17, 2023
View reviewed changes
@narendasan
Copy link
Copy Markdown
Collaborator

narendasan commented May 17, 2023

@wu6u3tw can you mirror these changes for the fx_ts_compat frontend as well? Doesnt need to be the same PR but these changes seem useful for that as well

narendasan
narendasan reviewed May 18, 2023
View reviewed changes
@wu6u3tw
Copy link
Copy Markdown
Contributor Author

wu6u3tw commented May 19, 2023

Yes, can do this on another PR.

@nvpohanh
Copy link
Copy Markdown
Contributor

nvpohanh commented May 19, 2023

Looks good to me now.

@wu6u3tw can you mirror these changes for the fx_ts_compat frontend as well? Doesnt need to be the same PR but these changes seem useful for that as well

@wu6u3tw Could you address @narendasan 's this comment? Thanks

@wu6u3tw
Copy link
Copy Markdown
Contributor Author

wu6u3tw commented May 19, 2023

Looks good to me now.

@wu6u3tw can you mirror these changes for the fx_ts_compat frontend as well? Doesnt need to be the same PR but these changes seem useful for that as well

@wu6u3tw Could you address @narendasan 's this comment? Thanks

Draft in prog. Will be PR out today.

@nvpohanh
Copy link
Copy Markdown
Contributor

nvpohanh commented May 24, 2023

@narendasan Anything blocking this PR from being merged?

@nvpohanh nvpohanh mentioned this pull request May 24, 2023
Merged
7 tasks
@narendasan
Copy link
Copy Markdown
Collaborator

narendasan commented May 30, 2023

We need @frank-wei or someone on Meta's side to review this since this is an API change that might effect their stack

@nvpohanh
Copy link
Copy Markdown
Contributor

nvpohanh commented Jun 21, 2023

@frank-wei Could you review this? It has been 3 weeks since last update

@narendasan
Copy link
Copy Markdown
Collaborator

narendasan commented Sep 22, 2023

We are just going to close this since its in dynamo

@narendasan narendasan closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narendasan narendasan narendasan left review comments

@frank-wei frank-wei Awaiting requested review from frank-wei

+1 more reviewer

@nvpohanh nvpohanh nvpohanh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed component: api [Python] Issues re: Python API component: fx fx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wu6u3tw @narendasan @nvpohanh @facebook-github-bot