fix: Allow full model compilation with collection inputs (input_signature)#1656
Merged
peri044 merged 2 commits intopytorch:mainfrom Mar 30, 2023
Merged
Conversation
|
Pending PR #1599 . |
a219e05 to
71ac294
Compare
Collaborator
|
@gs-olive Can you add collection example usage to our README https://github.com/pytorch/TensorRT#python ? And mention a line or two about how we can send collection inputs for an example model. You can add it there and also here https://pytorch.org/TensorRT/getting_started/getting_started_with_python_api.html (source) |
- Allow users to specify full model compilation when using `input_signature`, which allows for complex collection-based inputs - Enable "psuedo-partitioning" phase for input collections as well as output collections - Update `OutputIsCollection` to include dictionary outputs, and add function `InputIsCollection` to detect collection-based inputs during graph compilation - Remove automatic fallback for collection pack/unpack operations when using `input_signature` argument - Add collections tests to ensure full compilation is respected for input and output collections
- Add documentation to `README` for usage of input signature - Add documentation to "Getting Started" page for usage of input signature
71ac294 to
985f6a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
input_signature, which allows for complex collection-based inputsOutputIsCollectionto include dictionary outputs, and add functionInputIsCollectionto detect collection-based inputs during graph compilationinput_signatureargumentFixes #1602
Fixes #1293
Addresses #1595
Type of change
Checklist: