Skip to content

Update submodule asmjit#520

Closed
luncliff wants to merge 3 commits intopytorch:masterfrom
luncliff:update/asmjit
Closed

Update submodule asmjit#520
luncliff wants to merge 3 commits intopytorch:masterfrom
luncliff:update/asmjit

Conversation

@luncliff
Copy link
Copy Markdown

@luncliff luncliff commented Feb 24, 2021 •
edited
Loading

Changes

  • Update submodule asmjit to asmjit/asmjit@5a5fb8a
    • Replaced deprecated API usage
  • Add macos executor for build check
    Oh, I didn't know macos requires a pricing plan...

Related Issues?

The changes are for microsoft/vcpkg#16346

@luncliff luncliff closed this Feb 24, 2021
@luncliff luncliff deleted the update/asmjit branch February 24, 2021 02:49
@luncliff luncliff restored the update/asmjit branch February 24, 2021 02:49
@luncliff luncliff reopened this Feb 24, 2021
@luncliff luncliff changed the title Update submodule asmjit and Circle CI configuration Update submodule asmjit Feb 24, 2021
facebook-github-bot
facebook-github-bot reviewed Feb 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianyuh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dskhudia
Copy link
Copy Markdown
Contributor

dskhudia commented Feb 24, 2021

@luncliff May I know the reason for asmjit version upgrade?

@luncliff
Copy link
Copy Markdown
Author

luncliff commented Feb 24, 2021 •
edited
Loading

@luncliff May I know the reason for asmjit version upgrade?

I'd like to support this project as a package of https://github.com/microsoft/vcpkg.
It already supports asmjit, and it uses a later commit than the current master's submodule reference.

@luncliff luncliff mentioned this pull request Mar 1, 2021
Merged
2 tasks
@luncliff
Copy link
Copy Markdown
Author

luncliff commented Mar 5, 2021

@dskhudia, Is there anything I can do for this PR? Will be glad to hear from the maintainers :)

@dskhudia
Copy link
Copy Markdown
Contributor

dskhudia commented Mar 5, 2021

We have to upgrade asmjit for our internal code base before I can land this PR. Unfortunately I will have to create a new PR with these changes. Is it ok with you if we close this PR and land in a new PR?

@luncliff
Copy link
Copy Markdown
Author

luncliff commented Mar 5, 2021 •
edited
Loading

Of course. Feel free to close this for the next PR :)

@dskhudia
Copy link
Copy Markdown
Contributor

dskhudia commented Mar 10, 2021

Thanks a lot @luncliff for you PR. I have incorporated your changes in #538
Closing this.

@dskhudia dskhudia closed this Mar 10, 2021
@dskhudia dskhudia mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luncliff @dskhudia @facebook-github-bot