Fix potential deadlock if open_loop() is cancelled#128
Merged
tjstum merged 2 commits intopython-trio:masterfrom Dec 1, 2023
Merged
Fix potential deadlock if open_loop() is cancelled#128tjstum merged 2 commits intopython-trio:masterfrom
tjstum merged 2 commits intopython-trio:masterfrom
Conversation
…+await asyncio tasks on exit
Member
|
Nice fix. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #115. This also modifies the "cancel and await all asyncio tasks" logic to run even if
open_loop()is cancelled or sees an exception, because that's another potential source of deadlocks -- the Trio tasks in thetasks_nurserymight need to block on asyncio work as they unwind.