Skip to content

docs: Bump year automatically#465

Closed
pquentin wants to merge 2 commits intopython-trio:masterfrom
pquentin:docs-bump-year
Closed

docs: Bump year automatically#465
pquentin wants to merge 2 commits intopython-trio:masterfrom
pquentin:docs-bump-year

Conversation

@pquentin
Copy link
Copy Markdown
Member

@pquentin pquentin commented Mar 13, 2018

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2018 •
edited
Loading

Codecov Report

Merging #465 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   99.26%   99.03%   -0.23%     
==========================================
  Files          89       89              
  Lines       10361    12578    +2217     
  Branches      721     1235     +514     
==========================================
+ Hits        10285    12457    +2172     
- Misses         58       99      +41     
- Partials       18       22       +4
Impacted Files Coverage Δ
trio/_core/_io_windows.py 69.54% <0%> (-6.2%) ⬇️
trio/_util.py 97.48% <0%> (-2.52%) ⬇️
trio/_core/tests/test_ki.py 99.8% <0%> (-0.2%) ⬇️
trio/_threads.py 100% <0%> (ø) ⬆️
trio/tests/test_highlevel_ssl_helpers.py 100% <0%> (ø) ⬆️
trio/_core/_ki.py 100% <0%> (ø) ⬆️
trio/_core/_local.py 100% <0%> (ø) ⬆️
trio/tests/test_timeouts.py 100% <0%> (ø) ⬆️
trio/_core/tests/test_result.py 100% <0%> (ø) ⬆️
trio/tests/test_util.py 100% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae110f...a1e59df. Read the comment docs.

@nicoddemus nicoddemus mentioned this pull request Mar 13, 2018
Closed
@pquentin
Copy link
Copy Markdown
Member Author

pquentin commented Mar 14, 2018

Thanks. I can confirm your new commit is better and works. Let's wait a bit to see what happens to pytest-dev/pytest#3303 before merging this?

@nicoddemus
Copy link
Copy Markdown
Member

nicoddemus commented Mar 14, 2018

@pquentin we will go with the same approach used here. 👍

@pquentin
Copy link
Copy Markdown
Member Author

pquentin commented Mar 15, 2018

Thanks @nicoddemus for the follow-up!

@njsmith anything else to do before merging this?

@pquentin
Copy link
Copy Markdown
Member Author

pquentin commented Mar 23, 2018

gentle ping

@pquentin pquentin closed this Mar 29, 2018
@pquentin pquentin reopened this Mar 29, 2018
@pquentin
Copy link
Copy Markdown
Member Author

pquentin commented Apr 5, 2018

Is there anything I need to do? I'm not sure why the codecov/project check is red.

@Fuyukai
Copy link
Copy Markdown
Member

Fuyukai commented Apr 6, 2018

Maybe you should close this one and open another one to see if codecov fixes itself (it didn't seem to fix by close-reopening?)

@pquentin pquentin closed this Apr 23, 2018
@pquentin pquentin mentioned this pull request Apr 23, 2018
Closed
@pquentin pquentin deleted the docs-bump-year branch April 26, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pquentin @nicoddemus @Fuyukai @njsmith