add small tests and codecov skips to work on reaching 100%#2901
add small tests and codecov skips to work on reaching 100%#2901jakkdl merged 11 commits intopython-trio:masterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2901 +/- ##
==========================================
+ Coverage 99.55% 99.66% +0.10%
==========================================
Files 115 115
Lines 17668 17667 -1
Branches 3161 3157 -4
==========================================
+ Hits 17590 17608 +18
+ Misses 52 40 -12
+ Partials 26 19 -7
|
|
PyPy 7.3.0 was released in december 2019, and I have no clue how long it's been since trio last ran 7.2.X in CI, so I think users still running 7.2.X have bigger problems than buggy asyncgens. But pypy versioning is weird so ... maybe warrants a release note?? @A5rocks |
|
Looks like pypy 7.2.0 is only Python 3.6 so it's not in our supported versions anyways |
TeamSpen210
left a comment
There was a problem hiding this comment.
Increasing test coverage is good indeed.
CoolCat467
left a comment
There was a problem hiding this comment.
I think this looks great other than making sure we have a full discussion about the dtls handle_client_hello_untrusted thing
|
Pypy 3.10 segfaulted again: https://github.com/python-trio/trio/actions/runs/7200698782/job/19615211426 |
I think that requires more time/effort to fully delve into than it is worth, so I personally don't mind punting that to an unspecified time when somebody else works on the dtls stuff and stumbles upon it. Or if somebody reading this knows the dtls code well enough that they care to investigate and open a separate issue/PR. |
We're tantalizingly close, and I didn't find a setting for requiring the patch diff to be 100% without the project needing to be 100%, so might as well slowly work towards it. I noticed I've been authoring PRs with very minor misses - and easier to enforce 100% at time of authoring a PR than fix afterward.
We're at 52 missed lines on master/ currently