add newsfragment for issue #2611, PR #2826#2836
Merged
jakkdl merged 1 commit intopython-trio:masterfrom Oct 26, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2836 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 115 115
Lines 17514 17514
Branches 3125 3125
=======================================
Hits 17368 17368
Misses 101 101
Partials 45 45 |
Zac-HD
approved these changes
Oct 26, 2023
A5rocks
approved these changes
Oct 26, 2023
Contributor
A5rocks
left a comment
There was a problem hiding this comment.
I think the newsfragment is readable and I can't think of any great way to phrase it.
Member
Author
|
Thanks for the quick review! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2611, PR #2826
Accidentally forgot to add the requested newsfragment.
Not super happy with my sentence construction here, feel free to improve it or suggest changes.