Rock beats scissors, lizard beats spock, KeyboardInterrupt beats Cancelled#184
Merged
njsmith merged 1 commit intopython-trio:masterfrom Jun 4, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 98.44% 98.44% +<.01%
==========================================
Files 53 53
Lines 6116 6129 +13
Branches 476 476
==========================================
+ Hits 6021 6034 +13
Misses 80 80
Partials 15 15
Continue to review full report at Codecov.
|
…elled If we have a pending KeyboardInterrupt *and* a pending Cancelled, then deliver the KeyboardInterrupt. Rationale: when there are nested cancel scopes, we raise the outermost Cancelled exception. KeyboardInterrupt is the outerest cancellation.
cd0f278 to
e9d50eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have a pending KeyboardInterrupt and a pending Cancelled, then
deliver the KeyboardInterrupt.
Rationale: when there are nested cancel scopes, we raise the outermost
Cancelled exception. KeyboardInterrupt is the outerest cancellation.