Don't crash on C coroutine objects#1192
Merged
wgwz merged 7 commits intopython-trio:masterfrom Aug 18, 2019
Merged
Conversation
Member
|
You'll need to hide the async generator test from the 3.5 builds. Otherwise looks good. |
Codecov Report
@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
- Coverage 99.57% 99.56% -0.01%
==========================================
Files 106 106
Lines 12800 12818 +18
Branches 983 984 +1
==========================================
+ Hits 12745 12762 +17
- Misses 35 36 +1
Partials 20 20
|
Member
Author
|
So apparently my first version didn't work at all, because we were replacing |
Member
Author
|
We did some code review for this PR on gitter, starting here: https://gitter.im/python-trio/general?at=5d58b8434e17537f525114d7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: gh-550, gh-1191