broadcast telegram errors from run_async functions #785
Conversation
| self.received_message = update.message.text | ||
| self.message_count += 1 | ||
|
|
||
| @run_async |
There was a problem hiding this comment.
we need to convert the new unitests to pytest.
tsnoam
left a comment
There was a problem hiding this comment.
As discussed offline:
Jannes Höke, [12.08.17 18:58]
I think the reason why we were hesitating about this in the past was that it is not guaranteed that the decorated function is in fact a handler callback
Noam Meltzer, [12.08.17 19:00]
uhm. that's a good point.
i can think of another problem actually - this can create an endless loop of error handlers in case the error handler is run_async and has a bug which causes a TelegramError
|
Just a bump, since its quite restricting having to debug over an async stack trace without the update that caused it. Regarding the offline discussion:
Not much experience with Promises, but it would be amazing to have error handling for them |
fixes #682
Not sure if this is really the way to do it, IIRC there were some discussions about this in the dev group. Perhaps @Eldinnie can recall more details?