Allow for pattern matching empty inline queries #4817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you add a test which checks that this works now? If you would like pointers where/how feel free to ask, here or in the dev chat. |
Bibo-Joshi
requested changes
Jun 6, 2025
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the pr. I left a comment on the test below. please also
- have a look at the failing pre-commit run. Please run
pre-commit installin your local clone to ensure the hooks run before the commit. see also our contrib guide. running black viapip install black && black .should fix the current issues - add the file pointed out here. Use
bugfixesinstead ofother. You can change the text to a more descriptive explanation. It will appear in the changelog.
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Contributor
Author
I've done about everything I knew how to do from your request. Please review and let me know if something is missing and how to fix it. |
Bibo-Joshi
requested changes
Jun 14, 2025
Bibo-Joshi
approved these changes
Jun 15, 2025
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thank you very much for the contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just removed the line of code that prevents empty inline queries from being matched using the
patternparameter when creating an instance of anInlineQueryHandler.update.inline_queryis assumed to always have thequeryproperty, which I can only assume is always the case, as theupdate.inline_queryobject must not be None in this case anyway.Also added myself to AUTHORS.rst
I haven't modified any of the documentation as I feel like this changes makes the documentation more accurate, as the expected behavior is now in place.