Skip to content

Conversation

@harshil21
Copy link
Member

Fixes 2 things:

  • Available in admonition not appearing in certain classes like RefundedPayment. This happened because the regex didn't consider :obj: classes.
  • Insertion of admonitions will now consider putting it before "Args:".

@harshil21 harshil21 added bug 🐛 ⚙️ documentation affected functionality: documentation labels Aug 3, 2024
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good 👍 I expect it also renders fine? :D

@harshil21
Copy link
Member Author

yep 👍

@Bibo-Joshi Bibo-Joshi merged commit 1787586 into master Aug 3, 2024
@Bibo-Joshi Bibo-Joshi deleted the admonition-fix branch August 3, 2024 20:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 bug pr description: bug ⚙️ documentation affected functionality: documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants