Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Jul 13, 2024

closes #4373.
workflow triggers based on commit message regex do not seem to be easily possible.

To verify that both workflows are basically the same now, see cbee05d

Todo when merged:

  • update the how-to-release wiki page a bit more
  • update the test-pypi project to use the new workflow file name
  • update repo settings to forbid pushes to master also for admins (will no longer be necessary even for tags)
  • revert the temporary version and workflow trigger changes
  • include Bump sigstore/gh-action-sigstore-python from 2.1.1 to 3.0.0 #4409

@Bibo-Joshi Bibo-Joshi added the 🔗 github-actions related technology: github-actions label Jul 13, 2024
@Bibo-Joshi Bibo-Joshi temporarily deployed to release_test_pypi July 17, 2024 19:49 — with GitHub Actions Inactive
@Bibo-Joshi Bibo-Joshi temporarily deployed to release_test_pypi July 17, 2024 20:22 — with GitHub Actions Inactive
@Bibo-Joshi Bibo-Joshi temporarily deployed to release_test_pypi July 17, 2024 20:39 — with GitHub Actions Inactive
@Bibo-Joshi
Copy link
Member Author

image

seems to finally work correctly :) Cleanup (reverting temporary version & trigger changes) are still needed, but reviews are already welcome :)

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question

@Bibo-Joshi Bibo-Joshi merged commit b17b0d2 into master Sep 1, 2024
@Bibo-Joshi Bibo-Joshi deleted the improve-pypi-automation branch September 1, 2024 07:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔗 github-actions related technology: github-actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve PyPI Automation

3 participants