Use a Composite Action for Testing Type Completeness #4367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Interesting. Are there any functional changes to it apart from it being outsourced? Also, can you deliberately change something so that the test fails (so that I know it's actually working) 😅 |
Member
Author
currently PTB allows a 0.1% decrease of type completeness - I threw that out for now.
Will do :) |
Member
Author
|
well, shit :D |
Member
Author
|
all, right, here we go. failing workflow at https://github.com/python-telegram-bot/python-telegram-bot/actions/runs/9872648792/job/27263177990?pr=4367 caused by 7de2541 |
This reverts commit 7de2541.
harshil21
approved these changes
Jul 10, 2024
Member
harshil21
left a comment
There was a problem hiding this comment.
good thing that was tested!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outsources the code to a reusable component. I'm also using this in
aioremnow.