Add adjust_message_entities_to_utf_16 utility
#4323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Is there anything else should be added/changed? |
Bibo-Joshi
requested changes
Jun 26, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Hi, thank you very much for the PR! I left a number of comments. The overall logic is fine - thanks for catching the necessity for sorting! - but there are some things that can be improved :)
Contributor
Author
|
Ok, I will fix these in the next few days |
Bibo-Joshi
requested changes
Jul 1, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the updates! Left some more comments, mostly about documentation :)
Please don't force-push additional changes, as that makes it hard to see what which parts I've already reviewed.
harshil21
reviewed
Jul 1, 2024
Bibo-Joshi
approved these changes
Jul 5, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the additional updates! LGTM now :) If @harshil21 approves as well, we can merge.
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Member
|
Thank you very much for the nice contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
adjust_message_entities_to_utf_16for #4319