Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented May 21, 2024

This does two things:

  • Makes the updates run quarterly instead of weekly. IMO the monthly updates have been a bit too much in the past, especially since these are "just" code quality dependencies
  • Instead of using the default commit message [pre-commit.ci] pre-commit autoupdate it sets a commit message that is roughly in the same style as the dependabot commit messages. Probably mostly personal preference but at least the [pre-commit.ci] part is unnecessary IMO and so far I've always removed it.

See https://pre-commit.ci/#configuration for reference.

@Bibo-Joshi Bibo-Joshi requested review from clot27 and harshil21 May 21, 2024 09:03
@Bibo-Joshi Bibo-Joshi added the 🛠 code-quality change type: code-quality label May 21, 2024
@github-actions github-actions bot removed the 🛠 code-quality change type: code-quality label May 21, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (optional) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the additional dependencies for the hooks in sync with the requirements :)

@harshil21 harshil21 added the 🛠 code-quality change type: code-quality label May 21, 2024
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. But if I see a new ruff version with new features i'm definitely sending a pr asap

@Bibo-Joshi Bibo-Joshi merged commit 6ba7a09 into master May 22, 2024
@Bibo-Joshi Bibo-Joshi deleted the pre-commit-settings branch May 22, 2024 15:43
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🛠 code-quality change type: code-quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants