Fix annotation of decrypted_secret #4199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
reviewed
Apr 12, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just one question: Is the "# type: ignore" iin line 183 still necessary with your changes or can it be removed?
Contributor
Author
|
I think it is still necessary despite the change. |
Bibo-Joshi
approved these changes
Apr 13, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Ah, right … Then let's merge. Thanks for the contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4198
Fix type annotation of
self._decrypted_secretfrom str to bytes