Feat: Support passing socket directly #4161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
requested changes
Mar 24, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left a few comments below.
Tests don't seem to be happy:
tests.ext.test_updater
collection failure
ImportError while importing test module '/home/runner/work/python-telegram-bot/python-telegram-bot/tests/ext/test_updater.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/importlib/init.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/ext/test_updater.py:28: in <module>
from tornado.netutil import bind_unix_socket
E ModuleNotFoundError: No module named 'tornado'
Bibo-Joshi
reviewed
Mar 24, 2024
Bibo-Joshi
reviewed
Mar 24, 2024
Bibo-Joshi
approved these changes
Mar 24, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
LGTM :) When tests pass & pool can confirm his local tests, we can merge
Member
Author
|
@Bibo-Joshi Can confirm now, works. |
1 similar comment
Member
Author
|
@Bibo-Joshi Can confirm now, works. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to pass sockets instances instead of file paths.
Closes #4078