Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

Makes the regexes in pre-commit.yml opt-out instead of opt-in. That way we e.g. also cover setup.py. Also makes ruff apply to everything. started applying mypy to docs/ as well, but that quickly turned out to be just a burdon b/c of missing sphinx references etc, so not worth the enfort imo.

@Bibo-Joshi Bibo-Joshi added the 🛠 code-quality change type: code-quality label Feb 25, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (optional) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the additional dependencies for the hooks in sync with the requirements :)

@github-actions github-actions bot removed the 🛠 code-quality change type: code-quality label Feb 25, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@Bibo-Joshi Bibo-Joshi merged commit 26f9437 into master Feb 29, 2024
@Bibo-Joshi Bibo-Joshi deleted the more-pre-commit-power branch February 29, 2024 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants