Add missing slot to Updater
#4130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4127 and https://t.me/pythontelegrambottalk/246581 and https://t.me/pythontelegrambotgroup/715736.
The reason why this happened is because:
Updateris inheriting fromtyping.AsyncContextManagerwhich defines a__dict__on < 3.13, and that's why there's no error.The tests don't catch that because they assume there will be no
__dict__leaving it to Python to catch the error for us (we previously used to check for__dict__presence)We still don't fully support Python 3.13, and support for that will be added in a later PR, or once it reaches beta.
Thus, the patch is untested.