Make Updater.stop Independent of CancelledError
#4126
Conversation
|
All right, tests seem to be stuck. will have to debug on linux |
|
Test coverage seems to be fine and as expected adjusting the existing tests was already rather annoying, so tbh I'm not eager to try and add another unit test here. |
harshil21
left a comment
There was a problem hiding this comment.
code looks good. Didn't have a very close look at the tests.. they are kind of a black box because of so many Event's. I assume you ran an example bot on both Windows and linux and checked if Ctrl+C works well?
They are certainly not very pretty :/
Yes, I ran echobot & the example from #4125. |
See #4125 for discussion
Since the tests for these things usually don't run well on Windows, I haven't run the unit tests yet - let's see.
Adding new unit tests will also likely be chellanging. If the test coverage doesn't drop, I might be content with leaving as is 😬