Skip to content

Add Bot.do_api_request #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 10 commits into from
Feb 7, 2024
Merged

Add Bot.do_api_request #4084

Bibo-Joshi merged 10 commits into from
Feb 7, 2024

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Jan 28, 2024 •
edited
Loading

Closes #4053

  • add rate limit kwargs in ExtBot and make sure that tests also cover that

@Bibo-Joshi Bibo-Joshi added enhancement ⚙️ bot-api affected functionality: bot-api labels Jan 28, 2024
@Bibo-Joshi Bibo-Joshi marked this pull request as ready for review January 28, 2024 20:40
@Bibo-Joshi Bibo-Joshi changed the title WIP: Add Bot.do_api_request Add Bot.do_api_request Jan 28, 2024
Poolitzer
Poolitzer requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one phrasing request out of pride

@Bibo-Joshi Bibo-Joshi added the ℹ️ needs-wiki-update information: needs-wiki-update label Feb 4, 2024
clot27
clot27 reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@clot27 clot27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! just few nitpicks

@Bibo-Joshi Bibo-Joshi merged commit 29866e2 into master Feb 7, 2024
@Bibo-Joshi Bibo-Joshi deleted the feature-do-api-request branch February 7, 2024 21:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clot27 clot27 clot27 left review comments

@Poolitzer Poolitzer Poolitzer requested changes

Assignees

No one assigned

Labels

⚙️ bot-api affected functionality: bot-api 🔌 enhancement pr description: enhancement ℹ️ needs-wiki-update information: needs-wiki-update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Bot.do_api_request

4 participants

@Bibo-Joshi @Poolitzer @clot27