Feat: Introduce unix mode for webhook #3986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
reviewed
Nov 26, 2023
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Also improved tests and removed some checks
It is getting too late. Sry.
Bibo-Joshi
requested changes
Dec 9, 2023
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
also made a wrong decision when merging, fixed that
Bibo-Joshi
reviewed
Dec 13, 2023
Bibo-Joshi
approved these changes
Dec 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #3978. It might break on windows with the Path solution I came up with for the input to tornado.