Add JobQueue.scheduler_configuration and add corresponding warnings
#3913
Conversation
Co-authored-by: Dmitry K <58207913+lemontree210@users.noreply.github.com>
Co-authored-by: Dmitry K <58207913+lemontree210@users.noreply.github.com>
|
Please make sure you delete me from authors before merging, otherwise I'll be known for co-authoring a commit to master just because I changed one letter :) |
harshil21
left a comment
There was a problem hiding this comment.
Changes look good to me. However codecov is complaining about untested lines. Is it really not possible to test them?
|
macos py3.12 test consistently failing, but the errors aren't exactly related to this PR? |
|
Mh, codecov doesn't complain in their UI and I'm also pretty certain that the tests cover everything. Maybe the annotations just stuck from the initial runs … TBH I don't recall why the macos tests failed. Might have been due to codecov upload failure. I'm rerunning. |
harshil21
left a comment
There was a problem hiding this comment.
alright, test pass and code looks covered by the tests 👍🏽
Proposal for closing #3837
Makes the config values used by
JobQueuepublically accessible so that users can use them in addition to their custom values. Also adds warnigs that explain what this is about.@rejedai, would you mind also having a look at this, given that you reported the issue?
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSIONor.. deprecated:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__Added myself alphabetically toAUTHORS.rst(optional)Added new classes & modules to the docs and all suitable__all__sStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behaviorcloses #3837