Skip to content

Move test_official to separate workflow file #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 2 commits into from
Oct 2, 2023
Merged

Move test_official to separate workflow file #3912

Bibo-Joshi merged 2 commits into from
Oct 2, 2023

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Oct 1, 2023

  • Makes it a tad easier to spot the test in the test matrix below PRs
  • Makes it easier to rerun only failed tests other than test_official
  • Minimal code duplication of the workflow header

@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Oct 1, 2023
harshil21
harshil21 requested changes Oct 2, 2023
View reviewed changes
@Bibo-Joshi @harshil21
Update .github/workflows/test_official.yml
9167108 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Bibo-Joshi Bibo-Joshi merged commit 8cb177c into master Oct 2, 2023
@Bibo-Joshi Bibo-Joshi deleted the separate-workflow-files branch October 2, 2023 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@harshil21 harshil21 harshil21 approved these changes

@lemontree210 lemontree210 Awaiting requested review from lemontree210

@Poolitzer Poolitzer Awaiting requested review from Poolitzer

Assignees

No one assigned

Labels

⚙️ tests affected functionality: tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bibo-Joshi @harshil21