Skip to content

API 6.9 #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 14 commits into from
Oct 3, 2023
Merged

API 6.9 #3898

Bibo-Joshi merged 14 commits into from
Oct 3, 2023

Conversation

@harshil21
Copy link
Member

@harshil21 harshil21 commented Sep 23, 2023 •
edited by Bibo-Joshi
Loading

Checklist

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION or .. deprecated:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s
  • Checked the Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior
  • Create PR to remove functionality deprecated in this PR

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of the Stability Policy

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts api_kwargs as kw-only

  • Added new shortcuts:

    • In :class:~telegram.Chat & :class:~telegram.User for all methods that accept chat/user_id
    • In :class:~telegram.Message for all methods that accept chat_id and message_id
    • For new :class:~telegram.Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In :class:~telegram.CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id

  • If relevant:

    • Added new constants at :mod:telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard-coded numbers and strings
    • Add new message types to :attr:telegram.Message.effective_attachment
    • Added new handlers for new update types
    • Add the handlers to the warning loop in the :class:~telegram.ext.ConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to _extbot.py
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION_INFO
    • Added logic for arbitrary callback data in :class:telegram.ext.ExtBot for new methods that either accept a reply_markup in some form or have a return type that is/contains :class:~telegram.Message

@harshil21 harshil21 added the ⚙️ bot-api affected functionality: bot-api label Sep 23, 2023
github-actions[bot]
github-actions bot reviewed Sep 23, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@Poolitzer
Copy link
Member

Poolitzer commented Sep 25, 2023

Not sure with the versionchanged text at the promote shortcut and not sure if there should be a versionchanged within the message class where only the docstring was extended.

harshil21
harshil21 commented Sep 25, 2023
View reviewed changes
harshil21 and others added 2 commits September 25, 2023 15:07
@harshil21
Merge branch 'master' into api-6.9
9f84337
@Poolitzer @harshil21
Readd double quote
62869b0 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Bibo-Joshi
Bibo-Joshi requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice PR! I left a couple of minor comments. Additionally, kindly double check with the changes in https://t.me/bot_api_changes/96 & 97. I saw one change in WriteAccessAllowed & there are also a couple of changes in the can_* argument docstrings. Or did everything of that go into doc-fixes alngo with 3c2642f ?

@Bibo-Joshi Bibo-Joshi mentioned this pull request Sep 30, 2023
Closed
@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Oct 1, 2023

@harshil21 @Poolitzer is there anything to add from your side?

@Bibo-Joshi Bibo-Joshi mentioned this pull request Oct 1, 2023
Merged
4 tasks
@harshil21
Copy link
Member Author

harshil21 commented Oct 1, 2023

Nope, LGTM

@Bibo-Joshi Bibo-Joshi added this to the API 6.9 / 7.0 milestone Oct 2, 2023
Poolitzer
Poolitzer approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit ae57d3b into master Oct 3, 2023
@Bibo-Joshi Bibo-Joshi deleted the api-6.9 branch October 3, 2023 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees

No one assigned

Labels

⚙️ bot-api affected functionality: bot-api

Projects

None yet

Milestone

API 6.9 / 7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@harshil21 @Poolitzer @Bibo-Joshi