Skip to content

Extend Allowed Values for HTTP Version #3823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 2 commits into from
Aug 1, 2023
Merged

Extend Allowed Values for HTTP Version #3823

Bibo-Joshi merged 2 commits into from
Aug 1, 2023
+22 −11

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Jul 31, 2023 •
edited
Loading

Closes #3821

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION or .. deprecated:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • [ ] Documented code changes according to the CSI standard
  • [ ]Added myself alphabetically to AUTHORS.rst (optional)
  • [ ]Added new classes & modules to the docs and all suitable all s
  • Checked the Stability Policy in case of deprecations or changes to documented behavior

@Bibo-Joshi Bibo-Joshi added enhancement ⚙️ type-hinting affected functionality: type-hinting labels Jul 31, 2023
@Bibo-Joshi Bibo-Joshi mentioned this pull request Jul 31, 2023
Closed
harshil21
harshil21 reviewed Aug 1, 2023
View reviewed changes
harshil21
harshil21 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit ed3acd4 into master Aug 1, 2023
@Bibo-Joshi Bibo-Joshi deleted the http_v2_extension branch August 1, 2023 14:19
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@harshil21 harshil21 harshil21 approved these changes

Assignees

No one assigned

Labels

🔌 enhancement pr description: enhancement ⚙️ type-hinting affected functionality: type-hinting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Incorrect HTTPVersion type-alias

3 participants

@Bibo-Joshi @harshil21