document more about proxy_url and get_updates_proxy_url
#3816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshil21
requested changes
Jul 27, 2023
Member
harshil21
left a comment
There was a problem hiding this comment.
Thanks for the PR. I would be okay with adding this 'see also' note in all the (get_updates_)* methods in AppBuilder. What say others?
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Member
|
I would prefer to just add a |
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Bibo-Joshi
reviewed
Aug 2, 2023
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the updates! Would you mind also adding similar changes to the other get_updates_* methods and their counterparts?
Contributor
Author
I do mind... |
Member
|
Fair enough, thanks for the contribution in any case! |
This was referenced Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.