Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

We get questions like #3779 every now and then and adding the quotes doesn't hurt on systems that don't strictly need them afaik.

@Bibo-Joshi Bibo-Joshi requested review from clot27 and harshil21 June 26, 2023 18:42
@Bibo-Joshi Bibo-Joshi added the ⚙️ documentation affected functionality: documentation label Jun 26, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you recheck if all instances are replaced? I found a few:

@Bibo-Joshi Bibo-Joshi requested a review from harshil21 June 27, 2023 20:12
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Bibo-Joshi Bibo-Joshi merged commit 4a6e0fd into master Jun 29, 2023
@Bibo-Joshi Bibo-Joshi deleted the quotes-for-opt-deps branch June 29, 2023 05:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ documentation affected functionality: documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants