-
Notifications
You must be signed in to change notification settings - Fork 6k
Make JobQueues APS-Interface more explicit #3695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lemontree210
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much I can contribute here except probably ask for more clarity as to what benefits using this new method offers.
|
Another comment on this. This PR does not ensure that the classes
IMO making
|
harshil21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, lgtm
Inspired by python-telegram-bot/ptbcontrib#72 and python-telegram-bot/ptbcontrib#73
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)[ ] Added myself alphabetically toAUTHORS.rst(optional)[ ] Added new classes & modules to the docs and all suitable__all__s